fix(build): don't export all symbols to dynamic symbol table #16171
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we use
-rdynamic
for exporting Node API symbols to the symbol table.-rdynamic
will export all symbols, that means previously unused functions will not be optimized away introducing a lot of binary bloat. It can be seen here:This patch uses
-exported_symbol
and--export-dynamic-symbol
link flags (not as universal as-rdynamic
) to only mark Node API symbols to be put in the dynamic symbol table.