Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(unstable): add support for npm specifier cli arguments for 'deno cache' #16141

Merged
merged 1 commit into from
Oct 3, 2022
Merged

feat(unstable): add support for npm specifier cli arguments for 'deno cache' #16141

merged 1 commit into from
Oct 3, 2022

Conversation

bartlomieju
Copy link
Member

@bartlomieju bartlomieju commented Oct 3, 2022 •
edited
Loading

This commit adds support for npm specifier in "deno cache" subcommand.

$ deno cache --unstable npm:vite npm:chalk https://deno.land/std/http/file_server.ts

Besides downloading requested npm package(s), it will also download
necessary code from "std/node/".

Ref #15960

@bartlomieju bartlomieju mentioned this pull request Oct 3, 2022
Closed
25 tasks
@bartlomieju bartlomieju requested a review from dsherret October 3, 2022 20:54
@bartlomieju bartlomieju changed the title feat(unstable): add support for npm specifier in 'deno cache' feat(unstable): add support for npm specifiers in 'deno cache' Oct 3, 2022
dsherret
dsherret requested changes Oct 3, 2022
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment. I think we already have deno cache support.

cli/main.rs Show resolved Hide resolved
@dsherret dsherret changed the title feat(unstable): add support for npm specifiers in 'deno cache' feat(unstable): add support for npm specifier cli arguments for 'deno cache' Oct 3, 2022
dsherret
dsherret approved these changes Oct 3, 2022
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju merged commit fde9381 into denoland:main Oct 3, 2022
@bartlomieju bartlomieju deleted the npm_deno_cache branch October 3, 2022 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bartlomieju @dsherret