[bundle] Bundled code doesn't work as expected

[MariusVatasoiu]

Code bundled with deno bundle works different than deno run.

Steps to reproduce it:

This code works:

import { resize } from 'https://deno.land/x/[email protected]/mod.ts';

const portraitJPG = await resize(Deno.readFileSync("./portrait.jpg"), {width: 100});
Deno.writeFileSync('./portrait.small.jpg', portraitJPG);

But this code doesn't:

deno bundle https://deno.land/x/[email protected]/mod.ts index.bundle.js

import { resize } from './index.bundle.js';

const portraitJPG = await resize(Deno.readFileSync("./portrait.jpg"), {width: 100});
Deno.writeFileSync('./portrait.small.jpg', portraitJPG);

Expected result:

resize function should return an Uint8Arrray for the resized image and than should be written on the disk.

Actual result:

error: Uncaught Error: unknown JPEG marker f980
                        throw new Error("unknown JPEG marker " + fileMarker.toString(16));
                              ^
    at constructor.parse (file:///.../index.bundle.js:1155:31)

Deno version: 1.6.1

I used this image but should work with any .jpg file.

[kitsonk]

When you say "doesn't work" what happens?

What version of Deno?

[MariusVatasoiu]

@kitsonk I updated the issue with the error and Deno version.

[Nexxkinn]

Might be caused by deno messing up code execution order.

In my current version ( 1.6.0 ). This line of code in my repo:

// using oak framework
const app = new Application();
      app.use(router.routes());
      app.use(router.allowedMethods());

      app.addEventListener("listen", (ctx) => {
          console.log(`Serving requests at ${ctx.hostname}:${ctx.port}`)
      })
await app.listen( {hostname:config.hostname,port:config.port} )

will be bundled like this

const app2 = new Application();
app2.addEventListener("listen", (ctx)=>{
    console.log(`Serving requests at ${ctx.hostname}:${ctx.port}`);
});
await app2.listen({
    hostname: config.hostname,
    port: config.port
});

// some hundreds of lines later
app2.use(router.routes());
app2.use(router.allowedMethods());

causing an error like this:

error: Uncaught (in promise) TypeError: There is no middleware to process requests.
            throw new TypeError("There is no middleware to process requests.");
                  ^
    at Application.listen (file:///C:/Users/natha/Desktop/repos/downhost/dist/downhost.js:13102:19)
    at file:///C:/Users/natha/Desktop/repos/downhost/dist/downhost.js:13161:12

My solution would be not to bundling the module until deno fix this issue in future versions.

[FrageDev]

I've got the same problem as @Nexxkinn . I'm developing an API using oak with Deno 1.6.1 by using Typescript.
My API is working without any error (as far as I know) when I start it with deno run --allow-all app.ts
When I use deno compile app.ts and I start the app.exe I've got :

>app error: TypeError: There is no middleware to process requests. at Application.listen (file://$deno$/bundle.js:10697:19) at file://$deno$/bundle.js:10753:12

Seems bundle and compile has the same issue ?

[kitsonk]

cc/ @kdy1

[kdy1]

@kitsonk I'm now working to fix this issue. (Preserving order of statements within single module would be solution to this issue.)

Exam is over :)
Sorry for the delay.

[kitsonk]

No problem! 😁 Hopefully the exams went well!

[kdy1]

I think this is fixed by swc-project/swc#1264

[Nexxkinn]

Looking forward for this fix, thank you very much @kdy1 !

[kdy1]

This is fixed by new version of swc_bundler. (I've added test for it)

[MariusVatasoiu]

I still have this problem with Deno 1.6.3.

[ry]

This will be fixed in 1.7.0 which will be released next week, January 19th.