Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deno.compile doesn't rename imports #6393

Closed
leonelv opened this issue Jun 20, 2020 · 4 comments
Closed

Deno.compile doesn't rename imports #6393

leonelv opened this issue Jun 20, 2020 · 4 comments

Comments

@leonelv
Copy link

leonelv commented Jun 20, 2020

When using Deno.compile (v1.1.1), the output doesn't have the import paths with the correct ext

Compile config:

const [messages, result] = await Deno.compile(input, undefined, {
    target: 'es6',
    module: 'es6',
    lib: ['dom', 'esnext'],
  })

Source:

image

Output:

image

@wongjiahau
Copy link
Contributor

Can you provide what is the expected output?

@jeroenptrs
Copy link

jeroenptrs commented Aug 10, 2020

@wongjiahau In this case it should be ../../deps.js, but in the case of an external dependency like https://deno.land/[email protected]/examples/welcome.ts, it shouldn't rename because the js version does not exist.

@jeroenptrs
Copy link

Also I think this is the same issue as denoland/deno_emit#41

@kitsonk
Copy link
Contributor

kitsonk commented Aug 10, 2020

Correct, duplicate of denoland/deno_emit#41.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants