Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

discussion: Add --experimental flags for features that won't be stable for 1.0 #4334

Closed
lucacasonato opened this issue Mar 12, 2020 · 3 comments · Fixed by #4957
Closed

discussion: Add --experimental flags for features that won't be stable for 1.0 #4334

lucacasonato opened this issue Mar 12, 2020 · 3 comments · Fixed by #4957

Comments

@lucacasonato
Copy link
Member

These would be for all of the features which deno currently has but don't have a stable API yet.

An example of this are plugins (--experimental-plugins), which we probably can't stabilize before op crates (#2180) are added because they would probably share a lot of infrastructure in deno_core.

@lucacasonato lucacasonato changed the title Add --experimental flags for features that won't be stable for 1.0 discussion: Add --experimental flags for features that won't be stable for 1.0 Mar 12, 2020
@lucacasonato
Copy link
Member Author

Now that we have a --unstable runtime flag, the next question that comes up is if the unstable JS APIs should even be present on the Deno global if the --unstable flag is not present. I personally think they shouldn't. The next question after that is if the unstable ops should even get registered on the isolate if the flag is not present.

I think not exposing the unstable functions on the Deno global and unstable methods on classes like Process should be a 1.0 blocker. This would have to be combined with a lib.deno.unstable.d.ts file to correctly do type checking on the --unstable channel. @kitsonk did most of this work already in #4639.

@ry
Copy link
Member

ry commented Apr 27, 2020

Yes I think we should not expose them on the global and also update the types as @kitsonk did. I'd welcome an adaption of #4639

@lucacasonato
Copy link
Member Author

I’ll do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants