Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is untrusted code execution a goal of the project? #4303

Closed
jakajancar opened this issue Mar 9, 2020 · 2 comments
Closed

Is untrusted code execution a goal of the project? #4303

jakajancar opened this issue Mar 9, 2020 · 2 comments

Comments

@jakajancar
Copy link

The manual reads like it is, and there is --allow-read and such, but then there's #3401, which makes me think.

Also, the entire process uses a single v8 isolate, so I guess a separate deno process would have to be launched? And then stdout/stderr parsed to get errors etc.?

Context

I'm currently executing untrusted code just fine using C++/V8 directly, but I would like to add access to network:

  • fetch API
  • SSL/TLS
  • http(s) module imports

... while not exposing any more of the local machine.

Can Deno be a solution for this without adding a ton of new attack surface?

@teleclimber
Copy link

I'm not on the Deno team but my impression is that it is supposed to be a proper sandbox for running untrusted code.

If not the team should definitely update their description of Deno!

#3401 has been marked as a bug by the team which indicates they have the right idea but need time to execute. Personally I'm happy to give them the time and I am grateful that so far 1.0 has not been pushed out with known safety problems.

I also intend to use it as a sandbox, which is why I created this project that you might be interested in:

https://github.com/teleclimber/deno-sandbox-tests

(Note it currently suffers from a bug that causes false positives: teleclimber/deno-sandbox-tests#8)

@jakajancar
Copy link
Author

Cool project.

I see #3401 is not only a bug, but also marked as a 1.0 blocker, which makes me hopeful. Will continue there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants