-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deno.land/x not incrementing version of my module #22014
Comments
The issue is that you went over the module size limit (you can see that in your github webhook deliveries). |
@crowlKats Where are you seeing this? I am seeing a bunch of Also, I am not seeing a module size limit documented anywhere. Can you point me to a place where I can read more about it? It seems odd to me that I would reach such a limit. I have only been working on this project for a few months and am at about 15k lines of code. Surely other projects are much larger. |
that is extremely weird. The error would make me think that the webhook might be misconfigured, though I have never seen that kind of error. Internally, that error is not even attributed with any of your releases. what happens if you redeliver one of those failed webhooks? That weird behaviour aside, for reference, here is a status of one of the versions that failed: https://deno.com/status/19a30a63-3257-48e0-84ae-af309d29cd05 (usually this link would show up in the webhook response body). |
Yeah, it does seem weird. Especially since I haven't changed anything about the webhook since initially creating it.
The fact that the webhook had been working up to and including v0.1.0 makes me think that it isn't misconfigured.
After redelivering I get the same error:
Hm, I see. I wonder why my module is large given that it's only 15k LOC. It wouldn't be somehow including the gitignored |
I just realized that I had a large 45MB I did get two 504 errors with the webhooks though. But no information to debug with. |
I think the module size issue should be resolved now.
However, my module is still not being incremented. Also, my most recent two webhooks are getting the original |
@crowlKats Is there anything that can be done to sort of "reset" or "restart" my module? Maybe that would work now that the module size issue has been addressed. |
I was thinking about that error message
I figured that might be the issue, so I tried creating the new tag first and then just using the tag for my release. But it turned out that just creating the tag fixed stuff. Which makes sense given that the webhook is on tag creation. So I have figured out a workaround for my issue, but it still might be worth improving various things associated with this for the sake of others. |
apologies for the delay, as I was sick during last week. This is quite odd, since I'd assume that GitHub just creates a tag and would fire the tag creation event with it. |
@crowlKats No worries on the delay. I hope you are feeling better. |
Yes, thanks. |
It seems like this is working again? I see the last release is up to date with the repo tag? https://deno.land/x/[email protected] Pleas re-open if this is still an issue. |
I am working on
rfui
. I have followed the instructions on "Adding a module" to publish it to deno.land/x. Up until v0.1.0, it has worked. However, since v0.1.0, it has not worked.As seen in the tags and releases pages, I have released v0.1.1, v0.1.2, and v0.1.3. And the webhook is still set.
Why do I say it hasn't worked?
"rfui": "https://deno.land/x/[email protected]/mod.ts"
in a Fresh project leads to me having a"Module not found "https://deno.land/x/[email protected]/mod.ts".
errorThe text was updated successfully, but these errors were encountered: