Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deno.land/x not incrementing version of my module #22014

Closed
adamzerner opened this issue Jan 21, 2024 · 12 comments
Closed

deno.land/x not incrementing version of my module #22014

adamzerner opened this issue Jan 21, 2024 · 12 comments

Comments

@adamzerner
Copy link

adamzerner commented Jan 21, 2024

I am working on rfui. I have followed the instructions on "Adding a module" to publish it to deno.land/x. Up until v0.1.0, it has worked. However, since v0.1.0, it has not worked.

As seen in the tags and releases pages, I have released v0.1.1, v0.1.2, and v0.1.3. And the webhook is still set.

Why do I say it hasn't worked?

@crowlKats
Copy link
Member

The issue is that you went over the module size limit (you can see that in your github webhook deliveries).

@adamzerner
Copy link
Author

adamzerner commented Jan 21, 2024

@crowlKats Where are you seeing this? I am seeing a bunch of {"success":false,"info":"created ref is not tag"} responses (which I don't understand) but nothing about a module size limit.

Screenshot 2024-01-20 at 10 18 03 PM

Also, I am not seeing a module size limit documented anywhere. Can you point me to a place where I can read more about it?

It seems odd to me that I would reach such a limit. I have only been working on this project for a few months and am at about 15k lines of code. Surely other projects are much larger.

@crowlKats
Copy link
Member

that is extremely weird. The error would make me think that the webhook might be misconfigured, though I have never seen that kind of error. Internally, that error is not even attributed with any of your releases. what happens if you redeliver one of those failed webhooks?

That weird behaviour aside, for reference, here is a status of one of the versions that failed: https://deno.com/status/19a30a63-3257-48e0-84ae-af309d29cd05 (usually this link would show up in the webhook response body).

@adamzerner
Copy link
Author

adamzerner commented Jan 21, 2024

that is extremely weird.

Yeah, it does seem weird. Especially since I haven't changed anything about the webhook since initially creating it.

The error would make me think that the webhook might be misconfigured, though I have never seen that kind of error.

The fact that the webhook had been working up to and including v0.1.0 makes me think that it isn't misconfigured.

what happens if you redeliver one of those failed webhooks?

After redelivering I get the same error:

Screenshot 2024-01-20 at 11 33 29 PM

That weird behaviour aside, for reference, here is a status of one of the versions that failed: https://deno.com/status/19a30a63-3257-48e0-84ae-af309d29cd05 (usually this link would show up in the webhook response body).

Hm, I see. I wonder why my module is large given that it's only 15k LOC. It wouldn't be somehow including the gitignored node_modules or npm directories, would it?

@adamzerner
Copy link
Author

adamzerner commented Jan 21, 2024

I just realized that I had a large 45MB tailwindcss executable in this repo. I removed it in this commit and then released v0.1.4. It looks like it still isn't working though.

I did get two 504 errors with the webhooks though. But no information to debug with.

Screenshot 2024-01-20 at 11 52 40 PM

@adamzerner
Copy link
Author

I think the module size issue should be resolved now.

  • Looking at the link you provided, I was at 48 MB and the limit is 21 MB.
  • After removing that tailwindcss executable that was taking up 45MB I should be back down to 3 MB, which is way under 21 MB.
  • Looking on my local machine, my rfui directory is 61.5MB, but node_modules is 36.9 MB and .git is 24.1 MB, which leaves only 0.5 MB remaining. I'm not sure why there's the discrepancy between the 0.5 MB here and the 3 MB I predicted in the second bullet point, but it also doesn't seem like an issue since both are way below the 21 MB limit.

However, my module is still not being incremented.

Also, my most recent two webhooks are getting the original {"success":false,"info":"created ref is not tag"} response.

@adamzerner
Copy link
Author

@crowlKats Is there anything that can be done to sort of "reset" or "restart" my module? Maybe that would work now that the module size issue has been addressed.

@adamzerner
Copy link
Author

I was thinking about that error message {"success":false,"info":"created ref is not tag"}. I realized that my process is to go to https://github.com/adamzerner/rfui/releases/new, click "Choose a tag", and then create a new tag. It says:

Choose an existing tag, or create a new tag when you publish this release.

I figured that might be the issue, so I tried creating the new tag first and then just using the tag for my release. But it turned out that just creating the tag fixed stuff. Which makes sense given that the webhook is on tag creation.

So I have figured out a workaround for my issue, but it still might be worth improving various things associated with this for the sake of others.

@crowlKats
Copy link
Member

apologies for the delay, as I was sick during last week. This is quite odd, since I'd assume that GitHub just creates a tag and would fire the tag creation event with it.

@adamzerner
Copy link
Author

@crowlKats No worries on the delay. I hope you are feeling better.

@crowlKats
Copy link
Member

Yes, thanks.
I just published https://deno.land/x/[email protected] via a creating a tag by doing a github release, and it worked without problem. something odd is happening for sure.

@lucacasonato
Copy link
Member

It seems like this is working again? I see the last release is up to date with the repo tag? https://deno.land/x/[email protected]

Pleas re-open if this is still an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants