Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node:crypto.pseudoRandomBytes function is missing #21632

Closed
jacob-shuman opened this issue Dec 18, 2023 · 3 comments · Fixed by #21649
Closed

node:crypto.pseudoRandomBytes function is missing #21632

jacob-shuman opened this issue Dec 18, 2023 · 3 comments · Fixed by #21649
Assignees
Labels
bug Something isn't working correctly node compat

Comments

@jacob-shuman
Copy link

I'm currently trying to get the Slack Bolt js sdk running on Deno and have noticed that the crypto.pseudoRandomBytes is missing the actual implementation. This would be great to have added!

I also noticed this particular function is missing from the partial support list in the documentation: https://docs.deno.com/runtime/manual/node/compatibility.

@bartlomieju bartlomieju changed the title crypto.pseudoRandomBytes function is missing node:crypto.pseudoRandomBytes function is missing Dec 18, 2023
@bartlomieju bartlomieju added bug Something isn't working correctly node compat labels Dec 18, 2023
@littledivy
Copy link
Member

pseudoRandomBytes is a long deprecated in favour of randomBytes and should not be used. nodejs/node#22519

@littledivy
Copy link
Member

@jacob-shuman Can you share the stack trace? It would be useful to know which module is still using this API

@jacob-shuman
Copy link
Author

@jacob-shuman Can you share the stack trace? It would be useful to know which module is still using this API

Thank you for getting this added so quickly! I've tried setting bolt's log level to DEBUG but i'm not getting anything other than a single warning:

> deno --version && deno run --allow-env --allow-sys --allow-read --allow-net mod.ts

deno 1.39.0 (release, x86_64-apple-darwin)
v8 12.0.267.8
typescript 5.3.3
⚡️ Bolt app is running!
[WARN]   Parsing request body failed (error: TypeError: crypto.pseudoRandomBytes is not a function)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working correctly node compat
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants