Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deno check: Add a option to exclude specific files from type checking #18089

Closed
magurotuna opened this issue Mar 9, 2023 · 2 comments
Closed
Labels
cli related to cli/ dir duplicate a duplicate of another issue

Comments

@magurotuna
Copy link
Member

Now deno check command provides two options in terms of how many modules it's going to typecheck.

  • no option: only local modules are typechecked
  • --all: all modules including remote are typechecked

This suffices in almost all use cases, but it's going to be complicated if we want to perform typecheck within the project that vendors external dependencies using deno vendor. Vendored dependencies are considered "local" so deno check will check for vendored ones as well. This is sometimes troublesome if vendored dependencies have type errors that are known and acceptable.

So it would be great if we could have a new option, let's say --ignore=<ignore>, that make the type checker ignore type errors happening in the specified files. This way, specifying --ignore=vendor/ will allow us to ignore vendored dependencies.

@magurotuna magurotuna added the cli related to cli/ dir label Mar 9, 2023
@dsherret
Copy link
Member

dsherret commented Mar 9, 2023

I think this is a duplicate of #14797 or at least related to?

Also related (maybe this can just be an "exclude" option on the deno.json):

#17099
#15300

@magurotuna
Copy link
Member Author

Yes this PR is a complete duplicate of #14797 - I'm going to close this in favor of #14797

@magurotuna magurotuna added the duplicate a duplicate of another issue label Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli related to cli/ dir duplicate a duplicate of another issue
Projects
None yet
Development

No branches or pull requests

2 participants