Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node: support socket option in tls.connect #17842

Closed
kt3k opened this issue Dec 23, 2022 · 1 comment
Closed

node: support socket option in tls.connect #17842

kt3k opened this issue Dec 23, 2022 · 1 comment
Assignees
@kt3k
Labels
node compat

Comments

@kt3k
Copy link
Member

kt3k commented Dec 23, 2022

tls.connect takes socket and it can use that socket as a base tcp connect and start TLS on top of it. ref: https://nodejs.org/api/tls.html#tlsconnectoptions-callback

Currently std/node doesn't support this usage of tls.connect. This is necessary for supporting npm:mssql, npm:nodemailer etc.

related:
@kt3k kt3k self-assigned this Dec 23, 2022
@kt3k kt3k mentioned this issue Feb 21, 2023
Closed
14 tasks
@kt3k kt3k transferred this issue from denoland/std Feb 21, 2023
@mathe42 mathe42 mentioned this issue Apr 15, 2023
Open
@bartlomieju
Copy link
Member

Closing in favor of #18836

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kt3k kt3k

Labels
node compat
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kt3k @bartlomieju