Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Streams: reject pending reads when releasing reader #13369

Closed
MattiasBuelens opened this issue Jan 13, 2022 · 0 comments · Fixed by #13375
Closed

Streams: reject pending reads when releasing reader #13369

MattiasBuelens opened this issue Jan 13, 2022 · 0 comments · Fixed by #13375
Assignees
@crowlKats
Labels
ext/web related to the ext/web crate feat new feature (which has been agreed to/accepted)

Comments

@MattiasBuelens
Copy link
Contributor

MattiasBuelens commented Jan 13, 2022 •
edited
Loading

Previously, calling ReadableStreamDefaultReader.releaseLock() or ReadableStreamBYOBReader.releaseLock() while there are pending read() requests would throw a TypeError.

The specification has been changed to allow this case, and to reject such pending read() requests instead.

Standard change: whatwg/streams#1168
Tests: web-platform-tests/wpt#32072
@MattiasBuelens MattiasBuelens mentioned this issue Jan 13, 2022
Merged
6 tasks
@lucacasonato lucacasonato added ext/web related to the ext/web crate feat new feature (which has been agreed to/accepted) labels Jan 13, 2022
@crowlKats crowlKats self-assigned this Jan 14, 2022
@crowlKats crowlKats mentioned this issue Jan 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crowlKats crowlKats

Labels
ext/web related to the ext/web crate feat new feature (which has been agreed to/accepted)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(streams): reject pending reads when releasing reader crowlKats/deno
3 participants
@MattiasBuelens @lucacasonato @crowlKats