clippy

src/ops.rs

@@ -1107,10 +1107,7 @@ fn op_repl_start(
   let builder = &mut FlatBufferBuilder::new();
   let inner = msg::ReplStartRes::create(
     builder,
-    &msg::ReplStartResArgs {
-      rid: resource.rid,
-      ..Default::default()
-    },
+    &msg::ReplStartResArgs { rid: resource.rid },
   );
   ok_future(serialize_response(
     cmd_id,
@@ -1135,6 +1132,9 @@ fn op_repl_readline(
   let prompt = inner.prompt().unwrap().to_owned();
   debug!("op_repl_readline {} {}", rid, prompt);
 
+  // Ignore this clippy warning until this issue is addressed:
+  // https://github.com/rust-lang-nursery/rust-clippy/issues/1684
+  #[cfg_attr(feature = "cargo-clippy", allow(redundant_closure_call))]
   Box::new(futures::future::result((move || {
     let line = resources::readline(rid, &prompt)?;
 
@@ -1144,7 +1144,6 @@ fn op_repl_readline(
       builder,
       &msg::ReplReadlineResArgs {
         line: Some(line_off),
-        ..Default::default()
       },
     );
     Ok(serialize_response(

src/repl.rs

@@ -64,7 +64,7 @@ impl DenoRepl {
   pub fn new(history_file: PathBuf) -> DenoRepl {
     let mut repl = DenoRepl {
       editor: Editor::<()>::new(),
-      history_file: history_file,
+      history_file,
     };
 
     repl.load_history();
@@ -92,7 +92,7 @@ impl DenoRepl {
       })
   }
 
-  pub fn readline(&mut self, prompt: &String) -> DenoResult<String> {
+  pub fn readline(&mut self, prompt: &str) -> DenoResult<String> {
     self
       .editor
       .readline(&prompt)
@@ -115,7 +115,7 @@ impl Drop for DenoRepl {
   }
 }
 
-pub fn history_path(dir: &DenoDir, history_file: &String) -> PathBuf {
+pub fn history_path(dir: &DenoDir, history_file: &str) -> PathBuf {
   let mut p: PathBuf = dir.root.clone();
   p.push(history_file);
   p

src/resources.rs

@@ -232,7 +232,7 @@ pub fn add_repl(repl: DenoRepl) -> Resource {
 
 pub fn readline(
   rid: ResourceId,
-  prompt: &String, // TODO use &str for prompt
+  prompt: &str,
 ) -> DenoResult<String> {
   let mut table = RESOURCE_TABLE.lock().unwrap();
   let maybe_repr = table.get_mut(&rid);