Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra babel transform when upstream fixes land #234

Closed
davewasmer opened this issue Dec 8, 2016 · 3 comments
Closed

Remove extra babel transform when upstream fixes land #234

davewasmer opened this issue Dec 8, 2016 · 3 comments

Comments

@davewasmer
Copy link
Collaborator

Babel's regenerator implementation has a bug around nested arrow functions. So we added the arrow function transform to Babel so that the regenerator wouldn't encounter nested arrow functions. Once this PR lands, that bug will be fixed in Babel, so we can remove the redundant arrow transform.


We also added the class transform because async functions don't support super via babel: babel/babel#3930

@davewasmer
Copy link
Collaborator Author

The PR mentioned here has landed, so this is ready to be fixed

@davewasmer
Copy link
Collaborator Author

Closing these out since they belong in denali-babel.

@davewasmer
Copy link
Collaborator Author

Also, the class transform mentioned above has already been removed from denali-babel. The mentioned bug has not been fixed, but Babel's ES5 transpiled classes can't interop with native ES6 classes, so it's a shortcoming Babel users will have to deal with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant