Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.5.0 #384

Closed
50 of 51 tasks
lastmjs opened this issue May 13, 2023 · 0 comments · Fixed by #356
Closed
50 of 51 tasks

0.5.0 #384

lastmjs opened this issue May 13, 2023 · 0 comments · Fixed by #356

Comments

@lastmjs
Copy link
Member

lastmjs commented May 13, 2023

  • Documentation
    • document that the basic dfx deploy flow is what works, if you want to do anything else you'll have to manually figure it out
    • Explain that installer will now be your own canister
    • document that we only have 8 bytes of randomness instead of 32 temporarily
    • All new features
    • Explain that the binary hash is now useless
    • We need to explain in the docs that object unpacking shouldn't be used: Dictionary unpacking not working? RustPython/RustPython#4932
      • ethereum_json_rpc and outgoing_http_requests might have these problems
    • Explain in stable structures section that memory id 255/254 is taken
    • Memory ids 0, 1, 2, 233, 234 are all taken
    • breaking change...memory ids 0, 1, 2
    • document all contributor stuff
  • This means the sender and receiver type has diverged, and can cause data loss. this is happening in Kybra, I think it was fixed in Azle?
  • I removed guard functions entirely from init and post_upgrade, is that okay?
  • document the new issues with hashing, this should probably be in the security section
  • Make an MRE for this: Dictionary unpacking not working? RustPython/RustPython#4932
  • Make sure we are complying with the PSF license...are we a derivative work of Python? Not sure, we might just have to summarize the changes we've made
  • explain that init or post_upgrade may appear to work locally, but you should check the replica logs
  • Explain how if anything goes wrong during post_upgrade or pre_upgrade, it's all over basically
  • Wasmer is broken on Ma cM1...we need a different way to get Candid to work
  • Use the old Candid hacks to get the Candid out of the canister
  • Compiling the stdlib on the Mac M1 is taking a disturbingly long amount of time
  • password-protected dfx is probably going to be an issue with post_install
  • document that the canister:service metadata will be innacurrate on the first deploy but not the second
  • I think we should get rid of the candid:service metadata for the time being, I opened up the Candid UI and it was just blank until I deployed again. If I remove the metadata I think that will fix it
  • Fix naive candid parsing: Candid post_install parsing must be improved #433
  • Tell people that to upgrade to Kybra 0.5.0 they should delete ~/.config/kybra if it exists
  • Document all breaking changes
    • delete ~/.config/kybra
    • dfx.json: post_install, wasm path without .gz, and gzip
    • void now required
    • Vec now required/used?
    • removing candid metadata is a breaking change
  • Fix this issue: Opt["nat"] which results in The type nat is used, but never defined. Make sure all candid types are defined correctly
  • Document the --artificial-delay 0 thing
  • make sure to document service everywhere
  • Make an issue to go through Azle and test out all code examples, and especially to update the Candid main example
  • Make sure to fix Vec syntax everywhere in the Azle and Kybra books
  • uppercase Opt
  • Vec instead of list
  • uppercase variants
  • sign_with_ecdsa in azle reference has an incorrect link to an example
  • Major problem...projects without a did file that use init/post_upgrade params will not deploy...MUST BE FIXED
    • Open forum thread or issue about --argument candid inference
  • Explain that when adding init/post_upgrade params you may want to start clean, and you'll have to manually add the params to the service param list in the candid file
  • Go through the reference, especially updating Candid
  • Make sure to update the GitHub repo README.md as well, and make sure that it displays on PyPI
  • Go through the discord and all issues and make sure all documentation issues are addressed
  • Test dictionary unpacking everywhere (ethereum_json_rpc and outgoing_http_requests might have these problem) and update documentation if you must change these
  • add guard function documentation
  • open guard function issue for azle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant