Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Black can sometimes produce lines that are too long #88

Open
dpaiton opened this issue Jan 5, 2024 · 0 comments
Open

Black can sometimes produce lines that are too long #88

dpaiton opened this issue Jan 5, 2024 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@dpaiton
Copy link
Member

dpaiton commented Jan 5, 2024

black seems to have trouble with long variable names, resulting in files that have >120 char lines that black is not fixing. One fix we could do to hold off until black is improved is to always use the multi-line definitions:

def someLongFuncName(
  arg1: type = default,
  arg2: type = default,
) -> someLongReturnTypeName:

As opposed to our current pattern of always doing it on one line and letting black split it up if needed.

For reference, this can happen from the IERC4646Hyperdrive.sol contract.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant