EzETH and RETH redeployments

[jalextowle]

Resolved Issues

Description

Review Checklists

Please check each item before approving the pull request. While going
through the checklist, it is recommended to leave comments on items that are
referenced in the checklist to make sure that they are reviewed. If there are
multiple reviewers, copy the checklists into sections titled ## [Reviewer Name].
If the PR doesn't touch Solidity, the corresponding checklist can
be removed.

[[Reviewer Name]]

• Tokens
  • Do all approve calls use forceApprove?
  • Do all transfer calls use safeTransfer?
  • Do all transferFrom calls use msg.sender as the from address?
    • If not, is the function access restricted to prevent unauthorized
      token spend?
• Low-level calls (call, delegatecall, staticcall, transfer, send)
  • Is the returned success boolean checked to handle failed calls?
  • If using delegatecall, are there strict access controls on the
    addresses that can be called? It shouldn't be possible to delegatecall
    arbitrary addresses, so the list of possible targets should either be
    immutable or tightly controlled by an admin.
• Reentrancy
  • Are functions that make external calls or transfer ether marked as nonReentrant?
    • If not, is there documentation that explains why reentrancy is
      not a concern or how it's mitigated?
• Gas Optimizations
  • Is the logic as simple as possible?
  • Are the storage values that are used repeatedly cached in stack or
    memory variables?
  • If loops are used, are there guards in place to avoid out-of-gas
    issues?
• Visibility
  • Are all payable functions restricted to avoid stuck ether?
• Math
  • Is all of the arithmetic checked or guarded by if-statements that will
    catch underflows?
  • If Safe functions are altered, are potential underflows and
    overflows caught so that a failure flag can be thrown?
  • Are all of the rounding directions clearly documented?
• Testing
  • Are there new or updated unit or integration tests?
  • Do the tests cover the happy paths?
  • Do the tests cover the unhappy paths?
  • Are there an adequate number of fuzz tests to ensure that we are
    covering the full input space?

[coveralls]

Pull Request Test Coverage Report for Build 9974130645

Details

• 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 92.08%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
contracts/src/external/HyperdriveTarget0.sol	0	2	0.0%

Totals
Change from base Build 9947901785:	0.0%
Covered Lines:	2081
Relevant Lines:	2260

---

💛 - Coveralls

[github-actions]

Hyperdrive Gas Benchmark

Benchmark suite	Current: 22622c4	Previous: c6aaf87	Deviation	Status
addLiquidity: min	33893 gas	33893 gas	0%	🟰
addLiquidity: avg	196888 gas	197264 gas	-0.1906%	✅
addLiquidity: max	474728 gas	474728 gas	0%	🟰
checkpoint: min	40316 gas	40316 gas	0%	🟰
checkpoint: avg	144509 gas	144496 gas	0.0090%	🚨
checkpoint: max	256114 gas	256114 gas	0%	🟰
closeLong: min	31384 gas	31384 gas	0%	🟰
closeLong: avg	135908 gas	135982 gas	-0.0544%	✅
closeLong: max	2539399 gas	2539399 gas	0%	🟰
closeShort: min	31327 gas	31327 gas	0%	🟰
closeShort: avg	131274 gas	131301 gas	-0.0206%	✅
closeShort: max	400787 gas	271249 gas	47.7561%	🚨
initialize: min	31305 gas	31305 gas	0%	🟰
initialize: avg	352391 gas	352365 gas	0.0074%	🚨
initialize: max	418715 gas	418715 gas	0%	🟰
openLong: min	33370 gas	33370 gas	0%	🟰
openLong: avg	174284 gas	174111 gas	0.0994%	🚨
openLong: max	333715 gas	333715 gas	0%	🟰
openShort: min	33936 gas	33936 gas	0%	🟰
openShort: avg	174146 gas	174204 gas	-0.0333%	✅
openShort: max	414993 gas	415161 gas	-0.0405%	✅
redeemWithdrawalShares: min	31211 gas	31211 gas	0%	🟰
redeemWithdrawalShares: avg	74896 gas	75304 gas	-0.5418%	✅
redeemWithdrawalShares: max	305154 gas	305154 gas	0%	🟰
removeLiquidity: min	31217 gas	31217 gas	0%	🟰
removeLiquidity: avg	215494 gas	215097 gas	0.1846%	🚨
removeLiquidity: max	403546 gas	403546 gas	0%	🟰

This comment was automatically generated by workflow using github-action-benchmark.