Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parameterizing competition settings in infra #82

Merged
merged 10 commits into from
Oct 16, 2023
Merged

Parameterizing competition settings in infra #82

merged 10 commits into from
Oct 16, 2023

Conversation

slundqui
Copy link

No description provided.

@slundqui slundqui changed the title WIP PR for trading comp WIP Trading comp Oct 14, 2023
@slundqui slundqui force-pushed the tradecomp branch 2 times, most recently from db21954 to 1911e19 Compare October 16, 2023 21:43
ryangoree
ryangoree approved these changes Oct 16, 2023
View reviewed changes
@slundqui slundqui changed the title WIP Trading comp Parameterizing competition settings in infra Oct 16, 2023
@slundqui slundqui marked this pull request as ready for review October 16, 2023 23:32
jalextowle
jalextowle approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@jalextowle jalextowle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slundqui slundqui merged commit 7eb09f7 into main Oct 16, 2023
@slundqui slundqui deleted the tradecomp branch October 16, 2023 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryangoree ryangoree ryangoree approved these changes

@jalextowle jalextowle jalextowle approved these changes

@jrhea jrhea Awaiting requested review from jrhea

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@slundqui @ryangoree @jalextowle