-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Polish CI/CD workflows #73
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Aug 19, 2023
jalextowle
reviewed
Aug 19, 2023
jalextowle
reviewed
Aug 19, 2023
jalextowle
reviewed
Aug 19, 2023
jalextowle
reviewed
Aug 19, 2023
jalextowle
approved these changes
Aug 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some nits and questions. I'll leave it up to you as far as what you want to change.
ryangoree
force-pushed
the
ryan-ci-polish
branch
from
August 19, 2023 22:09
d039189
to
310ef3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
env.tags
toenv.images
and using the full image name. This is useful for testing with locally built or forked images..env
file created fromsetup_env.sh
services/
directory tocontainers/
test
directory, created a reusable workflow for running tests in thetest
directory.The container test has it's hyperdrive image name hardcoded in the test. This is because the version that the containers are being built for could be different than the one currently being used in
env.images
. For example, if hyperdrive is on0.0.11
and infra is on0.0.4
, then hyperdrive1.0.0
comes out which has breaking changes for infra, then the container test would be set to hyperdrive1.0.0
while they're in development. Once development finishes, both tags are bumped together inenv.images
.