Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish CI/CD workflows #73

Merged
merged 15 commits into from
Aug 19, 2023
Merged

Polish CI/CD workflows #73

merged 15 commits into from
Aug 19, 2023

Conversation

ryangoree
Copy link
Member

  • Made the full image names configurable by renaming env.tags to env.images and using the full image name. This is useful for testing with locally built or forked images.
  • Polished formatting for the .env file created from setup_env.sh
  • Renamed the services/ directory to containers/
  • Moved repeated container publishing workflow steps into a reusable workflow.
  • Moved the test code into scripts in a new test directory, created a reusable workflow for running tests in the test directory.

The container test has it's hyperdrive image name hardcoded in the test. This is because the version that the containers are being built for could be different than the one currently being used in env.images. For example, if hyperdrive is on 0.0.11 and infra is on 0.0.4, then hyperdrive 1.0.0 comes out which has breaking changes for infra, then the container test would be set to hyperdrive 1.0.0 while they're in development. Once development finishes, both tags are bumped together in env.images.

test/test_containers.sh Outdated Show resolved Hide resolved
Copy link
Contributor

@jalextowle jalextowle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some nits and questions. I'll leave it up to you as far as what you want to change.

@ryangoree ryangoree merged commit cd44688 into main Aug 19, 2023
4 checks passed
@ryangoree ryangoree deleted the ryan-ci-polish branch August 19, 2023 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create better infra checks Make docker registry/image name configurable
2 participants