-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using wallet deltas from transaction logs #772
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Remaining rate limit: 5000 🚀 |
Remaining rate limit: 4997 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes requested plz
did you just SAY changes requested? |
Remaining rate limit: 4994 🚀 |
do you think we'll ever find out what changes matthew requested? he's such a picky guy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved with dylan's review
3e8a8bb
to
f9d11be
Compare
Remaining rate limit: 4999 🚀 |
Remaining rate limit: 4992 🚀 |
Remaining rate limit: 4996 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Approved pending rewrite of the WalletDeltas db
Remaining rate limit: 4996 🚀 |
8829388
to
e511434
Compare
Remaining rate limit: 4996 🚀 |
This PR extracts position deltas from transaction logs. These deltas get fed into postgres, and the dashboard now uses these deltas for pnl calculations. This PR also adds these wallet deltas to the dashboard ticker.