Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using wallet deltas from transaction logs #772

Merged
merged 12 commits into from
Aug 1, 2023

Conversation

slundqui
Copy link

This PR extracts position deltas from transaction logs. These deltas get fed into postgres, and the dashboard now uses these deltas for pnl calculations. This PR also adds these wallet deltas to the dashboard ticker.

Screenshot 2023-07-31 at 4 43 41 PM

@vercel
Copy link

vercel bot commented Jul 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
elf-simulations ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 1, 2023 9:04pm

@github-actions
Copy link

Remaining rate limit: 5000 🚀

@github-actions
Copy link

Remaining rate limit: 4997 🚀

Copy link
Contributor

@sentilesdal sentilesdal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes requested plz

@wakamex
Copy link
Contributor

wakamex commented Aug 1, 2023

did you just SAY changes requested?

@github-actions
Copy link

github-actions bot commented Aug 1, 2023

Remaining rate limit: 4994 🚀

@wakamex
Copy link
Contributor

wakamex commented Aug 1, 2023

do you think we'll ever find out what changes matthew requested? he's such a picky guy

Copy link
Contributor

@sentilesdal sentilesdal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved with dylan's review

@github-actions
Copy link

github-actions bot commented Aug 1, 2023

Remaining rate limit: 4999 🚀

@github-actions
Copy link

github-actions bot commented Aug 1, 2023

Remaining rate limit: 4992 🚀

@github-actions
Copy link

github-actions bot commented Aug 1, 2023

Remaining rate limit: 4996 🚀

Copy link
Contributor

@sentilesdal sentilesdal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@dpaiton dpaiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Approved pending rewrite of the WalletDeltas db

@github-actions
Copy link

github-actions bot commented Aug 1, 2023

Remaining rate limit: 4996 🚀

@github-actions
Copy link

github-actions bot commented Aug 1, 2023

Remaining rate limit: 4996 🚀

@slundqui slundqui merged commit c77afb9 into delvtech:main Aug 1, 2023
@slundqui slundqui deleted the transactions_ticker branch August 1, 2023 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants