Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data pipeline to postgres #611

Merged
merged 23 commits into from
Jul 5, 2023
Merged

Conversation

slundqui
Copy link

@slundqui slundqui commented Jul 1, 2023

Reworks acquire_data.py to read/write to/from postgres instead of from file.

@vercel
Copy link

vercel bot commented Jul 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
elf-simulations ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 5, 2023 5:11pm

@slundqui slundqui force-pushed the postgres_updates branch from 411c83d to 4ceb668 Compare July 4, 2023 01:12
@slundqui slundqui marked this pull request as ready for review July 4, 2023 01:12
Copy link
Contributor

@dpaiton dpaiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments, but otherwise it looks great. Did you try syncing this up with the full demo pipeline (devnet -> bot trades -> postgres -> streamlit)? I think that would be a good test to do before merging.

@slundqui
Copy link
Author

slundqui commented Jul 5, 2023

Left some comments, but otherwise it looks great. Did you try syncing this up with the full demo pipeline (devnet -> bot trades -> postgres -> streamlit)? I think that would be a good test to do before merging.

This was tested with the demo pipeline.

@slundqui slundqui merged commit 6d2010c into delvtech:main Jul 5, 2023
@slundqui slundqui deleted the postgres_updates branch July 5, 2023 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants