Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] simplify deb-building with circle-ci #752

Merged
merged 22 commits into from
May 22, 2019
Merged

[wip] simplify deb-building with circle-ci #752

merged 22 commits into from
May 22, 2019

Conversation

hpk42
Copy link
Contributor

@hpk42 hpk42 commented Apr 2, 2019

Misses:

  • only build on master and new tags
  • upload builds to github

@ralphtheninja
Copy link
Member

@hpk42 So this will replace linux on Travis, right? In that case I think we should remove - linux from .travis.yml.

@hpk42 hpk42 changed the title simplify deb-building with circle-ci [wip] simplify deb-building with circle-ci Apr 3, 2019
@hpk42
Copy link
Contributor Author

hpk42 commented Apr 3, 2019 via email

@Jikstra
Copy link
Contributor

Jikstra commented Apr 3, 2019

It won't replace the -linux on travis because this only builds .debs and doesn't run any tests or anything. This should also only get triggered on new releases/tags.

@ralphtheninja
Copy link
Member

+845 rows. Seriously? :)

],
"include_dirs": [
"deltachat-core/src",
"<!(node -e \"require('napi-macros')\")"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the purpose of this file? And why do we need three versions of it? It's a nightmare to maintain.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some temporary hack until deltachat-node uses rpgp by default.

@Jikstra
Copy link
Contributor

Jikstra commented Apr 5, 2019

+845 rows. Seriously? :)

Currently all the build stuff is redundant for every ubuntu version. Some packagenames change or some commands or environment variables. I don't want to add an extra layer just to get down the lines of code. Also the binding.gyp files are redundant. I think even if this is a lot of "lines of code", this is all straight forward building shit. I prefer having many straight forward lines over having an extra layer which generates docker files and build contexts and shit.

My idea is following: First get it to work and do desktop releases on ubuntu which just work. Next step, push it up to the deltachat-node repository, fix the prebuilts, polish this. Maybe put the docker stuff in the docker hub (which makes prs again a nightmare). Not sure about how to make this more nice.

@Jikstra
Copy link
Contributor

Jikstra commented Apr 9, 2019

Pushing all this up to deltachat-node isn't that easy.
The biggest problem is that we can't bundle all the dependencies needed the same way as the python wheels do it or as it's possible on mac with install_name_tool. The problem is that patchelf isn't correctly patching the the deltachat.node elf file NixOS/patchelf#158. So I would still go with this solution until we can provide good and self contained prebuilts in deltachat-node.

@Jikstra Jikstra merged commit 0f844f7 into master May 22, 2019
@ralphtheninja ralphtheninja deleted the ci1 branch May 22, 2019 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants