-
-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wip] simplify deb-building with circle-ci #752
Conversation
everywhere were we need this information. No more hardcoding!
@hpk42 So this will replace linux on Travis, right? In that case I think we should remove |
On Wed, Apr 03, 2019 at 01:29 -0700, Lars-Magnus Skog wrote:
@hpk42 So this will replace linux on Travis, right? In that case I think we should remove `- linux` from `.travis.yml`.
i guess so. still need to sit with others to figure things out
as i am new to what happens with building with desktop.
just wanted to help along with circle-ci config and make
sure it's similar to how things are structured in
https://github.com/deltachat/deltachat-core/tree/master/ci_scripts
|
It won't replace the -linux on travis because this only builds .debs and doesn't run any tests or anything. This should also only get triggered on new releases/tags. |
+845 rows. Seriously? :) |
], | ||
"include_dirs": [ | ||
"deltachat-core/src", | ||
"<!(node -e \"require('napi-macros')\")" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the purpose of this file? And why do we need three versions of it? It's a nightmare to maintain.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some temporary hack until deltachat-node uses rpgp by default.
Currently all the build stuff is redundant for every ubuntu version. Some packagenames change or some commands or environment variables. I don't want to add an extra layer just to get down the lines of code. Also the binding.gyp files are redundant. I think even if this is a lot of "lines of code", this is all straight forward building shit. I prefer having many straight forward lines over having an extra layer which generates docker files and build contexts and shit. My idea is following: First get it to work and do desktop releases on ubuntu which just work. Next step, push it up to the deltachat-node repository, fix the prebuilts, polish this. Maybe put the docker stuff in the docker hub (which makes prs again a nightmare). Not sure about how to make this more nice. |
Pushing all this up to deltachat-node isn't that easy. |
Misses: