Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve css building for conversations stylesheets #573

Merged
merged 5 commits into from
Jan 10, 2019
Merged

Improve css building for conversations stylesheets #573

merged 5 commits into from
Jan 10, 2019

Conversation

Jikstra
Copy link
Contributor

@Jikstra Jikstra commented Jan 9, 2019 •
edited
Loading

  • Move /conversations/stylesheets to /css/conversations
  • Modify the npm run scripts accordingly
  • Put built .css file into /static/conversations.css
  • Include the conversations.css directly in the main.html without the ipc hack

Fixes #553

@Jikstra Jikstra requested a review from ralphtheninja January 9, 2019 17:45
ralphtheninja
ralphtheninja requested changes Jan 9, 2019
View reviewed changes
ralphtheninja
ralphtheninja requested changes Jan 9, 2019
View reviewed changes
ralphtheninja
ralphtheninja reviewed Jan 9, 2019
View reviewed changes
@Jikstra
Copy link
Contributor Author

Jikstra commented Jan 10, 2019

Nice, good finds @ralphtheninja !

Ayy readme also needs some work, will do that later

@Jikstra Jikstra merged commit 5d51f45 into master Jan 10, 2019
@Jikstra Jikstra deleted the fix_move_conversations_styles branch January 10, 2019 16:45
@ralphtheninja
Copy link
Member

Don't forget the watch script ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ralphtheninja ralphtheninja ralphtheninja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jikstra @ralphtheninja