Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UI to reset encryption #4312

Open
link2xt opened this issue Nov 3, 2024 · 3 comments
Open

Add UI to reset encryption #4312

link2xt opened this issue Nov 3, 2024 · 3 comments

Comments

@link2xt
Copy link
Collaborator

link2xt commented Nov 3, 2024

There is a core PR to adding JSON-RPC API to reset encryption:
deltachat/deltachat-core-rust#6170

It is needed to close deltachat/deltachat-core-rust#4465

"Reset Encryption" could be in the contact profile menu after "Encryption Info" or inside the Encryption Info dialog:
reset_encryption

Should probably be red as it is not a reversible action.

For chatmail profiles can be completely hidden as resetting encryption there in most cases makes it impossible to send messages. Could also be hidden if developer options are not enabled.

@r10s
Copy link
Member

r10s commented Nov 3, 2024

not sure if this meant as a developer option or not.
in both cases, the following would be fine:

  • let's put it as a button inside "encryption info", it is pretty advanced and should not be present in the primary ui.

  • should be a normal, unexcited button below the fingerprints. not sure if it needs to be "red", it is reversible when a new encrypted message comes in, this happens also automatically all the time without the user being asked

  • +1 for hiding for chatmail

@iequidoo
Copy link

iequidoo commented Nov 3, 2024

Technically it's easy to make it revertible, but then an extra translation is needed at least. I think if it's not a dev option, it should be red, otherwise i'm almost sure there will be complains why it's not possible to set encription back. But maybe just make it a dev option, do they require translation?

@Simon-Laux
Copy link
Member

"reset encryption" is not a good name, took me a while to figure out what is meant by that. If this is user visible it should have a clearer name and maybe also a link to an FAQ entry next to it that explains what it means

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants