Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chat-view does not scroll down on incoming message #1783

Closed
hpk42 opened this issue Jul 9, 2020 · 6 comments
Closed

Chat-view does not scroll down on incoming message #1783

hpk42 opened this issue Jul 9, 2020 · 6 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@hpk42
Copy link
Contributor

hpk42 commented Jul 9, 2020

current master of node + desktop today.
scroll-wrong

This worked with node/desktop-master 1-2 weeks ago.

@hpk42 hpk42 added the bug Something isn't working label Jul 9, 2020
@Simon-Laux Simon-Laux added this to the 1.5 milestone Jul 9, 2020
@ghost
Copy link

ghost commented Jul 9, 2020

@hpk42 Isn't this intentional? The v1.4.2 changelog says

Changed

  • We don't scroll down on incoming messages anymore

@Simon-Laux
Copy link
Member

@WhaleHub yes, but this isn't optimal. We still need to work on the chatview to make it nice.

@MustangDSG
Copy link

I think optimal is: if now a text already scrolled to the bottom, need to auto-scroll on incoming messages, if not, don't need to auto-scroll.

@r10s
Copy link
Member

r10s commented Jul 12, 2020

#1742 says, if the view is 7px close to end of list, scrolling down takes place, otherwise not.

maybe, these 7px are the issue and far too less. i would say sth as "height of window" or maybe some static 500px. if in doubt, a bit too much seems to be fine.

scrolling down is only an issue when scrolling up to read the backlog in a frequently used chat - but then it is really annoying and may prevent reading the backlog at all.

@hpk42
Copy link
Contributor Author

hpk42 commented Jul 13, 2020

i think i found at least one way to reproduce: if i am writing in a chat where the last message is from yesterday, then i will not see my own typed message -- only half of the day-marker. my own message that ijust type is invisible below

@Simon-Laux
Copy link
Member

was fixed in #1793

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants