Make appdata file compliant with the validator #1125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The images got moved with a37202c
The validator is unhappy about the lack of a common prefix, i.e. "v". hughsie/appstream-glib#333
Simon-Laux
reviewed
Nov 8, 2019
| @@ -25,7 +25,7 @@ | |||
| <launchable type="desktop-id">chat.delta.desktop.desktop</launchable> | |||
| <screenshots> | |||
| <screenshot type="default"> | |||
| <image>https://github.com/deltachat/deltachat-desktop/raw/master/screenshot.png</image> | |||
| <image>https://github.com/deltachat/deltachat-desktop/raw/master/README_ASSETS/screenshot.png</image> | |||
There was a problem hiding this comment.
how about changing this to an absolute commit to prevent a missing image when its path should change again?
There was a problem hiding this comment.
But then we need to update the path on every new screenshot push, which is probably fine. We can still change this if it actually makes trouble.
Jikstra
approved these changes
Nov 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are necessary to make the validator happy.
It'd be nice if the release would be filled out, though.
cf. hughsie/appstream-glib#333 and flathub/chat.delta.desktop#23