Select background #1001
Select background #1001
Conversation
Simon-Laux
commented
Sep 23, 2019
•
Simon-Laux
commented
- Logic
- Styling
- Translation Strings
|
Ah we still need to decide on the default background on all platforms for next release @r10s @Jikstra |
|
tbh, i would prefer a decision on that not now. as said, the potato-stamp is not my favorite, but when everyone likes it, we can go for it ;) but it could be technically better, though. but maybe we can also use different backgrounds in the upcoming release and sync them later. wfiw, ios currently has no background at all. |
Simon-Laux
force-pushed
the
select_background
branch
from
02f6144 to
3438d75
Compare
Simon-Laux
requested review from
Jikstra,
nicodh and
ralphtheninja
and removed request for
Jikstra and
nicodh
| const { saved } = app.state | ||
| saved[key] = value | ||
| app.saveState({ saved }) | ||
| render() | ||
| } | ||
| ipcMain.on('updateDesktopSetting', updateDesktopSetting) |
There was a problem hiding this comment.
Maybe do
ipcMain.on('updateDesktopSetting', (e, k, v) => updateDesktopSetting(k, v))There was a problem hiding this comment.
a new function... maybe more clearer, but us the definition is above it should be fine
| @@ -173,11 +173,34 @@ function init (cwd, state, logHandler) { | |||
| e.returnValue = app.localeData | |||
| }) | |||
|
|
|||
| ipcMain.on('updateDesktopSetting', (e, key, value) => { | |||
| const updateDesktopSetting = (e, key, value) => { | |||
There was a problem hiding this comment.
Maybe remove e since we don't use it?
| log.error('BG-IMG Copy Failed', err) | ||
| return | ||
| } | ||
| updateDesktopSetting(null, 'chatViewBgImg', `url("${newPath}")`) |
There was a problem hiding this comment.
.. and if so, remove null here :)
|
I saw some typos. However, I cannot create pull request because commits are conflicting. Please manually merge this commit. |
@OzancanKaratas Why are commits conflicting? It should work fine if you rebase your work on latest master or on this branch? |
|
@OzancanKaratas please make a new pr for this, It's not changing many typos that were introduced in this pr from what I can see with my sleepy eyes. Also the translations get also fixed on transifex sooner or later so I don't even know if it's worth the effort to do it right now. |
| /> | ||
| </ChatViewWrapper> | ||
| <SettingsContext.Consumer> | ||
| {(settings) => ( |
There was a problem hiding this comment.
Is it possible to use hooks here?
also change how the background is set. (otherwise updating would rebuild whole theme)
otherwise the "stamps" are too small
Simon-Laux
force-pushed
the
select_background
branch
from
46031cc to
2c81b83
Compare
