-
-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
show profiles connectivity state #3583
base: main
Are you sure you want to change the base?
Conversation
To test the changes in this pull request, install this apk: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Constantly shown green dot adds a bit of visual clutter, especially in the dark theme it is too bright. Not a big deal, I think I got used to it after opening the app a few times and I'm mostly in the chats anyway.
Still, I think it would be better if on the main screen default was no dot, and a green dot when connectivity is "working". In account switcher could be left as is, but cluttering the default state where you are connected and nothing happens is unnecessary.
src/main/java/org/thoughtcrime/securesms/components/AvatarView.java
Outdated
Show resolved
Hide resolved
+1 for showing nothing special, so no dot, when things are connected. this is also what we're doing in the main screen, and what try to suggested in the related issue. sorry, for confusion, i was not really aware that arcanechat also show the "connected dot" unconditionally on the main screen, this is indeed not needed. idea is to open as few questions as possible when the user opens the app. the "green dot" is also not the best choice as it is already in use with a slightly different meaning (if i see a green dot for myself, this does not mean that others see the green dot for me as well) so, i would change the PR to:
|
To clarify what I said was not to show anything special while UPDATING, when connected it makes sense to show the green dot this is what is done in desktop when hovering on profile and matches what you seen when other people are online |
yes, on desktop when hovering, this is far less visible. and also much smaller, compared to the screen size, and on a much less exposed position. so, for desktop it is fine, but i would not transfer that to android. as said, to raise even less questions, on iOS, we do not use dots but just show "Not connected" in the subtitle of profiles in the account switcher. but, also as said, i am fine with dots as well. but we should not show extra dots on android when things are just fine |
It is confusing if you go to the profile switcher and will not show state then? So user would not really know if account are connected until a problem actually occurs I think the dot is fine and is show in the chat list for contacts as well, if it changes from yellow to disappear, that is what user would actually expect for not connected at all |
let's continue that one-to-one or in a call |
cf7567d
to
78b3c38
Compare
To test the changes in this pull request, install this apk: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks for that!
also for tweaking the PR towards showing network-not-connected and not self-online-state.
"updating" state is not displayed, if we want to go for that, however, we should change yellow to green. but maybe it is not needed and fine. practise will tell.
i am not sure about the "red" color as my real device is not available atm, and somehow colors in the emulator are not accurate for me, but it is probably fine.
and we can also iterate :)
let's see how this works in practise :)
I agree with y'all that it's better to have less visual clutter in the app, and I agree with @adbenitez that green-when-connected-grey-when-disconnected is less visual clutter than nothing-when-connected-red-when-disconnected. We might remove the dot from the main screen (because there we anyway have the "Not connected" text) and put into the account switcher only, but then it's inconsistent... anyway, as @r10s we can also just try it out for some time and see how we like it. |
i would be up for removing the dot from the main screen. did i say that i personally would not use dots at all, but just say "Not Connected" as a text in the profile switcher as well? :) but i would suggest to move forward, merge it in as is and see how it feels in practise |
The problem with the text is that there is already a subtitle for tags or classic email accounts, then reusing it as well for connectivity is more problematic I think the dots are way more discrete / less disruptive, more if on top of that it would be a flacky subtitle appearing and disappearing when connected and making the title dance from top to centered vertically |
as said, i am fine with the dots. but the subtitle is also a nice solution, i would not say the one or the other is better. i am using it on iOS since weeks, and it is not disturbing, too flacky, disruptive or looks strange in any way. with or without private tags. it is just kind of a "status line" most times it is just hidden and profile switcher look as always. and: most time the whole profile switcher is not even open :) |
"Connected" state does not even mean connection is actually usable, you may have a connected state but NAT has forgot about you, packets are not routed anymore, the server has crashed a minute ago without telling you etc. So no dot even technically is more correct than a green dot. For me preferred solution would be:
|
close #3575