Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adapt to new saved-messages api #3573

Closed
5 tasks done
r10s opened this issue Feb 1, 2025 · 1 comment · Fixed by #3073
Closed
5 tasks done

adapt to new saved-messages api #3573

r10s opened this issue Feb 1, 2025 · 1 comment · Fixed by #3073
Labels
enhancement actually in development, user visible enhancement

Comments

@r10s
Copy link
Member

r10s commented Feb 1, 2025

since deltachat/deltachat-core-rust#5606 we have a new saved-messages-api; to benefit from that on android, the following steps are needed:

  • make dc_save_msgs(), dc_msg_get_original_msg_id() and dc_msg_get_saved_msg_id() available in java

  • when long tapping a regular message (not info 1), show save/unsave menu option. in case of android, this should be a ★ in the action bar, directly accessible (not the overflow menu). in self-chat, the "unsave" button should be shown unconditionally, so also for message saved otherwise. an unsave-confirmation is only needed if there is no original message

  • for every message shown in a chat, check if it was saved. if so, show a little ★ beside the date (screenshot)

  • in self-chat, for incoming messages, show group avatar and sender name, this is a simple one-line-change as drafted already at 75e9984

  • add a button to go to the original beside each saved message in the self-chat (screenshot)

Footnotes

  1. at least for the first iteration, we do not want to show saved info messages and thelike in the "Saved Messages" chat; this turned out to be confusing and might also require adaptions on systems other than android (remember: saved messages are synced), cmp. https://github.com/deltachat/deltachat-ios/issues/2567

@r10s r10s added the bug label Feb 1, 2025
@r10s
Copy link
Member Author

r10s commented Feb 1, 2025

@adbenitez i am up to resurrect and adapt my old PR that covers the first 4 points. as i did that on iOS, i still have the cornercases in mind. but i would be happy if you can take care of the last one (in a subsequent PR then)

@r10s r10s added enhancement actually in development, user visible enhancement and removed bug labels Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement actually in development, user visible enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant