Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Opening files in external apps always works now #3585

Merged
merged 2 commits into from
Feb 6, 2025

Conversation

Hocuri
Copy link
Collaborator

@Hocuri Hocuri commented Feb 5, 2025

The problem was that we returned null from getType().

fix #3517

The problem was that we returned `null` from `getType()`.
@Hocuri Hocuri requested review from r10s and adbenitez February 5, 2025 16:29
@adbenitez adbenitez added the bug label Feb 5, 2025
Copy link

github-actions bot commented Feb 5, 2025

To test the changes in this pull request, install this apk:
📦 app-preview.apk

Copy link
Member

@r10s r10s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@Hocuri Hocuri merged commit e3809cf into main Feb 6, 2025
2 checks passed
@Hocuri Hocuri deleted the hoc/fix-opening-pdfs branch February 6, 2025 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't open attached PDF of message in extern application
3 participants