Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Define Service FileType only 1 time instead of 2 times #49

Open
Abrom8 opened this issue Aug 21, 2023 · 0 comments
Open
Labels
Type: Enhancement Feature enhancement request

Comments

@Abrom8
Copy link
Collaborator

Abrom8 commented Aug 21, 2023

Motivation / Problem

Service FileType is defined as 2nd parameter on instance creation and in the urlFile object. This should be streamlined and only be defined once to prevent mistakes.

    const serviceBuilder = new ServiceBuilder(ServiceTypes.ACCESS, FileTypes.URL) 

    const urlFile: UrlFile = {
        type: 'url',
        url: 'https://bitcoin.org/bitcoin.pdf',
        method: 'GET'
    }
@Abrom8 Abrom8 added the Type: Enhancement Feature enhancement request label Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Feature enhancement request
Projects
None yet
Development

No branches or pull requests

1 participant