[SPARK][TEST-ONLY] Add more tests for Identity Column #3526
Conversation
| val commands: Map[Int, () => Dataset[_]] = Map( | ||
| 1 -> (() => spark.table(tblName)), | ||
| 2 -> (() => sql(s"SELECT * FROM $tblName")), | ||
| 3 -> (() => sql(s"SELECT * FROM delta.`$path`")), | ||
| 4 -> (() => spark.read.format("delta").load(path)), | ||
| 5 -> (() => spark.read.format("delta").table(tblName)), | ||
| 6 -> (() => spark.readStream.format("delta").load(path)), | ||
| 7 -> (() => spark.readStream.format("delta").table(tblName)) | ||
| ) |
There was a problem hiding this comment.
We either don't need the indices here or we just make it the parameter (Int) => Dataset[]. They're just used for "test number". Let's simplify this.
spark/src/test/scala/org/apache/spark/sql/delta/IdentityColumnSuite.scala
Show resolved
Hide resolved
|
The PR description could be more descriptive. The list of tests is pretty short so it's not verbose to do it in this case :) |
zhipengmao-db
changed the title
|
Failed test https://github.com/delta-io/delta/actions/runs/10351172194/job/28649104059?pr=3526 PTAL. Flaky? |
|
@zhipengmao-db do we have any tests for Identity + MERGE? I'm not sure if the implementation is already done though |
The failed test is |
MERGE support has not been done yet but it is on the plan |
Which Delta project/connector is this regarding?
Description
This PR is part of #1959 .
It add more tests for Identity Column to test
How was this patch tested?
Test only change.
Does this PR introduce any user-facing changes?
No.