Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spark] Add IdentityColumn.scala #2916

Merged
merged 1 commit into from
Apr 18, 2024
Merged

[Spark] Add IdentityColumn.scala #2916

merged 1 commit into from
Apr 18, 2024

Conversation

c27kwan
Copy link
Contributor

@c27kwan c27kwan commented Apr 18, 2024

Which Delta project/connector is this regarding?

  • Spark
  • Standalone
  • Flink
  • Kernel
  • Other (fill in here)

Description

This PR is part of #1959

In this PR, we introduce IdentityColumn.scala, a common file which contains most of the helpers for Identity Columns, necessary for unblocking future PRs.

How was this patch tested?

This PR commits dead code. Existing tests pass.

Does this PR introduce any user-facing changes?

No.

@c27kwan
Copy link
Contributor Author

c27kwan commented Apr 18, 2024

@larsk-db can you approve this? I split this from #2857

@c27kwan
Copy link
Contributor Author

c27kwan commented Apr 18, 2024

I made this its own PR since it is already approved and it is necessary as part of both #2857 and #2915

Copy link
Contributor

@larsk-db larsk-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@c27kwan
Copy link
Contributor Author

c27kwan commented Apr 18, 2024

This PR is trivial and has no impact on the rest of the codebase, so I'm going to ask for it to be merged to unblock the development of the other PRs.

@tdas tdas merged commit 659617b into delta-io:master Apr 18, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants