Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize Min/Max using Delta metadata #1525

Closed
Closed
Show file tree
Hide file tree
Changes from 9 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -528,7 +528,7 @@ object Protocol {
}
if (manifestGenerationEnabled) {
// Only allow enabling this, if there are no DVs present.
if (!DeletionVectorUtils.isTableDVFree(spark, snapshot)) {
if (!DeletionVectorUtils.isTableDVFree(snapshot)) {
throw new DeltaTablePropertyValidationFailedException(
table = tableName,
subClass = ExistingDeletionVectorsWithIncrementalManifestGeneration)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ trait DeletionVectorUtils {
* Run a query on the delta log to determine if the given snapshot contains no deletion vectors.
* Return `false` if it does contain deletion vectors.
*/
def isTableDVFree(spark: SparkSession, snapshot: Snapshot): Boolean = {
def isTableDVFree(snapshot: Snapshot): Boolean = {
val dvsReadable = deletionVectorsReadable(snapshot)

if (dvsReadable) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,7 @@ trait GenerateSymlinkManifestImpl extends PostCommitHook with DeltaLogging with
}

protected def assertTableIsDVFree(spark: SparkSession, snapshot: Snapshot): Unit = {
if (!isTableDVFree(spark, snapshot)) {
if (!isTableDVFree(snapshot)) {
throw DeltaErrors.generateNotSupportedWithDeletionVectors()
}
}
Expand Down
Loading
Loading