Add python api for optimize #1091
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@burakyilmaz321 Thank you for the PR. This is very good! For tests, you can look at the the examples here. |
burakyilmaz321
force-pushed
the
python-api-optimize
branch
from
220cf61 to
d82049b
Compare
burakyilmaz321
changed the title
|
@vkorukanti Added unit tests and documentation. Since the Scala API is not added yet, tests are failing here. But, I merged #961 with my changes in another branch, just to see that unit tests are passing. You can see here the unit test checks are successful. |
vkorukanti
reviewed
Apr 29, 2022
vkorukanti
requested changes
May 3, 2022
There was a problem hiding this comment.
Thank you @burakyilmaz321 for the update. Few minor comments. The Scala API is merged to master branch.
Signed-off-by: Burak Yilmaz <[email protected]>
It cannot decorate classes Signed-off-by: Burak Yilmaz <[email protected]>
Signed-off-by: Burak Yilmaz <[email protected]>
Signed-off-by: Burak Yilmaz <[email protected]>
Signed-off-by: Burak Yilmaz <[email protected]>
It's better to have a consistent naming between APIs. Signed-off-by: Burak Yilmaz <[email protected]>
After Python 3.6, there should not be escape characters in literal strings. Currently, it is just a lint issue. But it will eventually raise a SyntaxError in the future. Just make them raw strings to fix the issue. https://docs.python.org/3/whatsnew/3.6.html#deprecated-python-behavior Signed-off-by: Burak Yilmaz <[email protected]>
Signed-off-by: Burak Yilmaz <[email protected]>
burakyilmaz321
force-pushed
the
python-api-optimize
branch
from
506fade to
013aa48
Compare
Signed-off-by: Burak Yilmaz <[email protected]>
burakyilmaz321
force-pushed
the
python-api-optimize
branch
from
013aa48 to
9ec76f0
Compare
vkorukanti
approved these changes
May 4, 2022
|
@burakyilmaz321 The python test failures on |
Sure, I will do that as soon as I reach my laptop later today. |
jbguerraz
pushed a commit
to jbguerraz/delta
that referenced
this pull request
Jul 6, 2022
## Description Adds optimize command to the Python API. - New class in ``tables.py``: ``DeltaOptimizeBuilder`` - New method: ``DeltaTable.optimize`` Resolves delta-io#1080 Added new unit tests to ``test_deltatable.py``: - ``test_optimize`` - ``test_optimize_w_partition_filter`` ## Does this PR introduce _any_ user-facing changes? No Closes delta-io#1091 Signed-off-by: Venki Korukanti <[email protected]> GitOrigin-RevId: 93ede77656227f068c1cd32157e6cc46a78922e8
jbguerraz
pushed a commit
to jbguerraz/delta
that referenced
this pull request
Jul 6, 2022
## Description Adds optimize command to the Python API. - New class in ``tables.py``: ``DeltaOptimizeBuilder`` - New method: ``DeltaTable.optimize`` Resolves delta-io#1080 Added new unit tests to ``test_deltatable.py``: - ``test_optimize`` - ``test_optimize_w_partition_filter`` ## Does this PR introduce _any_ user-facing changes? No Closes delta-io#1091 Signed-off-by: Venki Korukanti <[email protected]> GitOrigin-RevId: 93ede77656227f068c1cd32157e6cc46a78922e8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds optimize command to the Python API.
tables.py:DeltaOptimizeBuilderDeltaTable.optimizeResolves #1080
How was this patch tested?
Added new unit tests to
test_deltatable.py:test_optimizetest_optimize_w_partition_filterDoes this PR introduce any user-facing changes?
No