Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delta Does not Build Under Java > 8 #4122

Open
anoopj opened this issue Feb 5, 2025 · 1 comment
Open

Delta Does not Build Under Java > 8 #4122

anoopj opened this issue Feb 5, 2025 · 1 comment
Labels
bug Something isn't working

Comments

@anoopj
Copy link
Collaborator

anoopj commented Feb 5, 2025

Bug

Describe the problem

Steps to reproduce

  1. git clone https://github.com/delta-io/delta.git
  2. build/sbt compile (with a newer JVM: I can repro this with Java 11 and Java 17, both on OSX and Ubuntu

Observed results

Compilation errors

[error] /home/anoop/delta/iceberg/src/main/scala/org/apache/spark/sql/delta/icebergShaded/IcebergConversionTransaction.scala:35:8: not found: object shadedForDelta
[error] import shadedForDelta.org.apache.iceberg.{AppendFiles, DeleteFiles, OverwriteFiles, PendingUpdate, RewriteFiles, Transaction => IcebergTransaction}

This happened because the build script used in Uniform (delta/icebergShaded/generate_iceberg_jars.py) fails because of a Gradle error.

With JDK8, the build succeeds cleanly.

Expected results

Users should be able to build/test Delta with newer JDK versions.

@anoopj anoopj added the bug Something isn't working label Feb 5, 2025
@anoopj
Copy link
Collaborator Author

anoopj commented Feb 11, 2025

I think this happened because delta/icebergShaded/generate_iceberg_jars.py checks out an older version of Iceberg with a specific commit hash. In that version, Iceberg Gradle build requires JDK 8 or 11 to be used. Newer versions of Iceberg support JDK 11, 17 and 21.

So this is pretty much an Iceberg upgrade problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant