Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: mention AWS_ENDPOINT_URL_DYNAMODB #3021

Merged

Conversation

maxitg
Copy link
Contributor

@maxitg maxitg commented Nov 23, 2024

Description

Document AWS_ENDPOINT_URL_DYNAMODB in storage_options, as it's not obvious that it's separate and not inferred from AWS_ENDPOINT_URL.

Related Issue(s)

@maxitg maxitg requested a review from MrPowers as a code owner November 23, 2024 06:26
@maxitg maxitg force-pushed the document-aws-endpoint-url-dynamodb branch from c6c70a2 to 0dd7889 Compare November 23, 2024 06:27
Copy link

codecov bot commented Nov 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.40%. Comparing base (cd9c9d5) to head (0dd7889).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3021      +/-   ##
==========================================
- Coverage   72.41%   72.40%   -0.01%     
==========================================
  Files         128      128              
  Lines       40859    40859              
  Branches    40859    40859              
==========================================
- Hits        29586    29585       -1     
+ Misses       9361     9358       -3     
- Partials     1912     1916       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@ion-elgreco ion-elgreco added this pull request to the merge queue Nov 23, 2024
Merged via the queue into delta-io:main with commit 0d076a7 Nov 23, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants