Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clean up some non-datafusion builds #2303

Merged
merged 1 commit into from
Mar 19, 2024

Commits on Mar 19, 2024

  1. fix: clean up some non-datafusion builds

    Not sure when this regressed but the lack of datafusion broke the core
    build
    
    error[E0432]: unresolved import `crate::delta_datafusion`
     --> crates/core/src/operations/transaction/conflict_checker.rs:5:12
      |
    5 | use crate::delta_datafusion::DataFusionMixins;
      |            ^^^^^^^^^^^^^^^^ could not find `delta_datafusion` in the crate root
    
    error[E0700]: hidden type for `impl Iterator<Item = actions::Add>` captures lifetime that does not appear in bounds
       --> crates/core/src/operations/transaction/conflict_checker.rs:196:9
        |
    109 | impl<'a> TransactionInfo<'a> {
        |      -- hidden type `impl Iterator<Item = actions::Add> + 'a` captures the lifetime `'a` as defined here
    ...
    195 |     pub fn read_files(&self) -> Result<impl Iterator<Item = Add>, CommitConflictError> {
        |                                        ------------------------- opaque type defined here
    196 |         Ok(self.read_snapshot.file_actions().unwrap().into_iter())
        |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    
    Some errors have detailed explanations: E0432, E0700.
    rtyler authored and ion-elgreco committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    b5e39f3 View commit details
    Browse the repository at this point in the history