Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update datafusion to 30, arrow to 45 #1606

Merged
merged 1 commit into from
Aug 31, 2023
Merged

Conversation

scsmithr
Copy link
Contributor

Description

Updates datafusion to 30, and arrow to 45.

Related Issue(s)

N/A

Documentation

N/A

@github-actions
Copy link

ACTION NEEDED

delta-rs follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

rust/src/delta_datafusion.rs Outdated Show resolved Hide resolved
@@ -1180,11 +1180,11 @@ pub(super) mod zorder {
.map(|i| (i * value_size) as i32)
.collect::<Vec<i32>>();

let out_arr = BinaryArray::new_unchecked(
let out_arr = BinaryArray::try_new(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new_unchecked was made unsafe. This does the same thing, just with some validation checks. I'm not aware of any significant performance hits with this extra check.

@@ -1,6 +1,7 @@
[workspace]
members = ["rust", "python"]
exclude = ["proofs", "delta-inspect"]
resolver = "2"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rust 1.72 emits a warning about not specifying this now. "2" is the default.

@scsmithr scsmithr changed the title chore: Update datafusion to 30, arrow to 45 chore: update datafusion to 30, arrow to 45 Aug 29, 2023
@wjones127
Copy link
Collaborator

Would you be willing to fix that Python test? should just need to replace the expected output.

https://github.com/delta-io/delta-rs/actions/runs/6015750742/job/16318366781?pr=1606#step:9:168

@github-actions github-actions bot added the binding/python Issues for the Python package label Aug 29, 2023
@scsmithr
Copy link
Contributor Author

Would you be willing to fix that Python test? should just need to replace the expected output.

https://github.com/delta-io/delta-rs/actions/runs/6015750742/job/16318366781?pr=1606#step:9:168

Updated in latest commit.

scsmithr added a commit to GlareDB/glaredb that referenced this pull request Aug 29, 2023
scsmithr added a commit to GlareDB/glaredb that referenced this pull request Aug 29, 2023
@rtyler
Copy link
Member

rtyler commented Aug 31, 2023

Would you mind rebasing this branch @scsmithr ? I just merged @wjones127 changes which simplified some changes and removed some of the deprecation warnings

@github-actions github-actions bot removed the binding/python Issues for the Python package label Aug 31, 2023
@scsmithr
Copy link
Contributor Author

Would you mind rebasing this branch @scsmithr ? I just merged @wjones127 changes which simplified some changes and removed some of the deprecation warnings

Done

@rtyler rtyler merged commit 787c13a into delta-io:main Aug 31, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binding/rust Issues for the Rust crate rust
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants