-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update datafusion to 30, arrow to 45 #1606
Conversation
ACTION NEEDED delta-rs follows the Conventional Commits specification for release automation. The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. |
@@ -1180,11 +1180,11 @@ pub(super) mod zorder { | |||
.map(|i| (i * value_size) as i32) | |||
.collect::<Vec<i32>>(); | |||
|
|||
let out_arr = BinaryArray::new_unchecked( | |||
let out_arr = BinaryArray::try_new( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new_unchecked
was made unsafe. This does the same thing, just with some validation checks. I'm not aware of any significant performance hits with this extra check.
@@ -1,6 +1,7 @@ | |||
[workspace] | |||
members = ["rust", "python"] | |||
exclude = ["proofs", "delta-inspect"] | |||
resolver = "2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rust 1.72 emits a warning about not specifying this now. "2" is the default.
Would you be willing to fix that Python test? should just need to replace the expected output. |
Updated in latest commit. |
Upstream pr for delta-rs: delta-io/delta-rs#1606
Upstream pr for delta-rs: delta-io/delta-rs#1606
Would you mind rebasing this branch @scsmithr ? I just merged @wjones127 changes which simplified some changes and removed some of the deprecation warnings |
Done |
Description
Updates datafusion to 30, and arrow to 45.
Related Issue(s)
N/A
Documentation
N/A