Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tiny typo in AggregatedStats #1516

Merged
merged 2 commits into from
Jul 6, 2023
Merged

fix: tiny typo in AggregatedStats #1516

merged 2 commits into from
Jul 6, 2023

Conversation

haruband
Copy link
Contributor

@haruband haruband commented Jul 4, 2023

Description

This PR fix typo in AggregatedStats.

Related Issue(s)

Documentation

@github-actions github-actions bot added binding/rust Issues for the Rust crate rust labels Jul 4, 2023
@wjones127
Copy link
Collaborator

Thanks for doing this; this seems obvious right but I'm concerned about the fact that our unit tests didn't catch this. We are testing min values here:

// assert on min values
for (k, v) in stats.min_values.iter() {
match (k.as_str(), v) {

Do you know why this missed this? Is this a different code path?

@haruband
Copy link
Contributor Author

haruband commented Jul 6, 2023

@wjones127
Our unit tests have only one row group, so we couldn't test the cases which use add_assign for AggregatedStats. I added new commit to fix it.

@wjones127 wjones127 merged commit 6c47273 into delta-io:main Jul 6, 2023
@haruband haruband deleted the fix-aggregated-stats-typo branch July 7, 2023 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binding/rust Issues for the Rust crate rust
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't get stats's minValues in add actions
2 participants