Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create and bind Delta Schema structures with pyo3 for Python. #95

Closed
fvaleye opened this issue Feb 28, 2021 · 4 comments · Fixed by #684
Closed

Create and bind Delta Schema structures with pyo3 for Python. #95

fvaleye opened this issue Feb 28, 2021 · 4 comments · Fixed by #684
Labels
binding/python Issues for the Python package enhancement New feature or request good first issue Good for newcomers

Comments

@fvaleye
Copy link
Collaborator

fvaleye commented Feb 28, 2021

Currently, we use a JSON string for binding Rust and Python for reading the Delta table schema. The improvement is to create and use pyo3 structure in Rust for binding the Schema.

@houqp houqp added binding/python Issues for the Python package enhancement New feature or request good first issue Good for newcomers labels Feb 28, 2021
@houqp
Copy link
Member

houqp commented Feb 28, 2021

I am thinking of releasing a new version of the python binding, @fvaleye do you want me to wait for this before doing the release?

@fvaleye
Copy link
Collaborator Author

fvaleye commented Mar 1, 2021

It's a good idea to release a new version 👍 I will take some time in the next weeks to work on it. In the mean time, the bindings for the schema will be available.

@roeap
Copy link
Collaborator

roeap commented May 15, 2022

@fvaleye, @houqp - this is done here, so we can close this, right?

struct RawDeltaTableMetaData {

@houqp
Copy link
Member

houqp commented May 16, 2022

@roeap I think that's something separate. We are currently still using passing the schema from rust to python through string ser/de, see

def from_json(cls, json_data: str) -> "Schema":

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binding/python Issues for the Python package enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants