Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lakefs: during file operations, skip merge when 0 changes #3190

Open
ion-elgreco opened this issue Feb 4, 2025 · 0 comments
Open

lakefs: during file operations, skip merge when 0 changes #3190

ion-elgreco opened this issue Feb 4, 2025 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@ion-elgreco
Copy link
Collaborator

ion-elgreco commented Feb 4, 2025 •
edited
Loading

Description

Use Case
If the branch has no commited files/zero changes, don't merge branch, so that we don't get an empty commit.

Should happen before:

delta-rs/crates/lakefs/src/logstore.rs

Lines 161 to 163 in 9dc8f32

match self
.client
.merge(

Related Issue(s)
@ion-elgreco ion-elgreco added enhancement New feature or request good first issue Good for newcomers labels Feb 4, 2025
@ion-elgreco ion-elgreco changed the title lakefs integration: during file operations, check branch diff lakefs integration: during file operations, skip merge when 0 changes Feb 4, 2025
@ion-elgreco ion-elgreco changed the title lakefs integration: during file operations, skip merge when 0 changes lakefs: during file operations, skip merge when 0 changes Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ion-elgreco