Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACUUM doesn't create a commit in transaction log #1726

Closed
ion-elgreco opened this issue Oct 14, 2023 · 3 comments · Fixed by #1728
Closed

VACUUM doesn't create a commit in transaction log #1726

ion-elgreco opened this issue Oct 14, 2023 · 3 comments · Fixed by #1728
Labels
bug Something isn't working

Comments

@ion-elgreco
Copy link
Collaborator

When you vacuum a table with delta-rs, it doesn't create a commit in the delta transaction log, stating the VACUUM operation.

@ion-elgreco ion-elgreco added the bug Something isn't working label Oct 14, 2023
@ion-elgreco ion-elgreco changed the title Vacuum doesn't create a commit in transaction log VACUUM doesn't create a commit in transaction log Oct 14, 2023
@wjones127
Copy link
Collaborator

Does it do that in Spark? I wouldn't expect it to create a transaction.

@ion-elgreco
Copy link
Collaborator Author

ion-elgreco commented Oct 14, 2023

@wjones127 apparently they do since this PR: delta-io/delta#1552

Also here is an example: https://books.japila.pl/delta-lake-internals/demo/vacuum/#vacuum-retain-0-hours at the bottom of the page.

@ion-elgreco
Copy link
Collaborator Author

@wjones127 I checked my tables written with databricks, and they all have the VACUUM START/END commits

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants