Skip to content

Commit

Permalink
fix: more fixes after rebase
Browse files Browse the repository at this point in the history
  • Loading branch information
roeap authored and rtyler committed Jun 5, 2024
1 parent 59d9f22 commit bc3bdb7
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions crates/core/src/operations/create.rs
Original file line number Diff line number Diff line change
Expand Up @@ -606,15 +606,15 @@ mod tests {
// Fail to create table with unknown Delta key
let table = CreateBuilder::new()
.with_location("memory://")
.with_columns(schema.fields().clone())
.with_columns(schema.fields().cloned())
.with_configuration(config.clone())
.await;
assert!(table.is_err());

// Succeed in creating table with unknown Delta key since we set raise_if_key_not_exists to false
let table = CreateBuilder::new()
.with_location("memory://")
.with_columns(schema.fields().clone())
.with_columns(schema.fields().cloned())
.with_raise_if_key_not_exists(false)
.with_configuration(config)
.await;
Expand Down
2 changes: 1 addition & 1 deletion crates/core/src/operations/transaction/protocol.rs
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ impl ProtocolChecker {
if (4..7).contains(&min_writer_version) {
debug!("min_writer_version is less 4-6, checking for unsupported table features");
if let Ok(schema) = snapshot.metadata().schema() {
for field in schema.fields.iter() {
for field in schema.fields() {
if field.metadata.contains_key(
crate::kernel::ColumnMetadataKey::GenerationExpression.as_ref(),
) {
Expand Down

0 comments on commit bc3bdb7

Please sign in to comment.