Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unit tests #56

Merged
merged 3 commits into from
Dec 1, 2023
Merged

Fix unit tests #56

merged 3 commits into from
Dec 1, 2023

Conversation

adamginna-dell
Copy link
Contributor

@adamginna-dell adamginna-dell commented Dec 1, 2023 •
edited
Loading

PR Submission checklist

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#771

Common PR Checklist:

  • Have you made sure that the code compiles?
  • Have you commented your code, particularly in hard-to-understand areas
  • Have you maintained backward compatibility

Description of your changes:

Small fix unit tests after adding access zone to functions.

mdutka-dell
mdutka-dell approved these changes Dec 1, 2023
View reviewed changes
Copy link

@mdutka-dell mdutka-dell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nitesh3108 nitesh3108 merged commit 1955b06 into main Dec 1, 2023
1 check failed
@nitesh3108 nitesh3108 deleted the fix_unit_tests branch December 1, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbartoszDell cbartoszDell cbartoszDell approved these changes

@mdutka-dell mdutka-dell mdutka-dell approved these changes

@nitesh3108 nitesh3108 nitesh3108 approved these changes

@bpjain2004 bpjain2004 Awaiting requested review from bpjain2004 bpjain2004 is a code owner

@chimanjain chimanjain Awaiting requested review from chimanjain chimanjain is a code owner

@prablr79 prablr79 Awaiting requested review from prablr79 prablr79 is a code owner

@rajkumar-palani rajkumar-palani Awaiting requested review from rajkumar-palani rajkumar-palani is a code owner

@Sakshi-dell Sakshi-dell Awaiting requested review from Sakshi-dell Sakshi-dell is a code owner

@shefali-malhotra shefali-malhotra Awaiting requested review from shefali-malhotra shefali-malhotra is a code owner

@meggm meggm Awaiting requested review from meggm meggm is a code owner

@HarishH-DELL HarishH-DELL Awaiting requested review from HarishH-DELL HarishH-DELL is a code owner

@bogdanNovikovDell bogdanNovikovDell Awaiting requested review from bogdanNovikovDell

@Leonard-Dell Leonard-Dell Awaiting requested review from Leonard-Dell

@mareksuski-dell mareksuski-dell Awaiting requested review from mareksuski-dell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adamginna-dell @nitesh3108 @mdutka-dell @cbartoszDell