Adding CSI Spec v1.6.0 support for Powerflex #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KshitijaKakde
requested review from
abhi16394,
adarsh-dell,
AkshaySainiDell,
ashleyvjoy,
bharathsreekanth,
Deepak-Ghivari and
JacobGros
as code owners
KshitijaKakde
requested review from
kumarkgosa,
mbasha-dell,
mjsdell,
Prabhu-Dell,
rishabhatdell,
sakshi-garg1,
suryagupta4 and
VamsiSiddu-7
as code owners
adarsh-dell
reviewed
Oct 30, 2023
adarsh-dell
reviewed
Oct 30, 2023
adarsh-dell
reviewed
Oct 30, 2023
service/controller.go
Outdated
| @@ -2132,9 +2139,75 @@ func (s *service) GetCapacity( | |||
| "Unable to get capacity: %s", err.Error()) | |||
| } | |||
|
|
|||
| systemID := "" | |||
| for key, value := range params { | |||
There was a problem hiding this comment.
@KshitijaKakde We have already retrieved the systemID from the request body so I believe we can remove this duplicate code here, what do you think?
adarsh-dell
reviewed
Oct 30, 2023
service/controller.go
Outdated
| if err != nil { | ||
| Log.Debug("GetMaxVolumeSize returning error ", err) | ||
| } | ||
| maxVolSizeinbps := maxVolSize * bytesInGiB |
There was a problem hiding this comment.
@KshitijaKakde Perform this (maxVolSizeinbps := maxVolSize * bytesInGiB) operation after if maxVolSize < 0 check.
adarsh-dell
reviewed
Oct 31, 2023
service/controller.go
Outdated
| @@ -2132,11 +2139,83 @@ func (s *service) GetCapacity( | |||
| "Unable to get capacity: %s", err.Error()) | |||
| } | |||
|
|
|||
| Log.Println("defaulttttttttt", s.opts.defaultSystemID) | |||
There was a problem hiding this comment.
Typo * => Log.Println("defaulttttttttt", s.opts.defaultSystemID), Please fix this.
adarsh-dell
previously approved these changes
Oct 31, 2023
Signed-off-by: Kshitija Kakde <[email protected]>
KshitijaKakde
force-pushed
the
CSI-1.6-changes
branch
from
3ad02ba to
4c0ee26
Compare
VamsiSiddu-7
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding CSI Spec v1.6.0 support for Powerflex
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Tested the changes by executing 2vols helm test and cert-csi
[root@master-1-UBC3iTe13Py54 ~]# ./cert-csi certify --cert-config /root/certify.yaml --vsc vxflexos-snapclass
[2023-10-30 06:31:54] INFO Starting cert-csi; ver. 0.8.1
[2023-10-30 06:31:54] INFO Suites to run with vxflexos storage class:
[2023-10-30 06:31:54] INFO 1. ScalingSuite {replicas: 2, volumes: 5, volumeSize: 8Gi}
[2023-10-30 06:31:54] INFO 2. CloneVolumeSuite {pods: 2, volumes: 1, volumeSize: 8Gi}
[2023-10-30 06:31:54] INFO 3. VolumeIoSuite {volumes: 2, volumeSize: 8Gi chains: 2-2}
[2023-10-30 06:31:54] INFO 4. VolumeExpansionSuite {pods: 1, volumes: 1, size: 8Gi, expSize: 16Gi, block: false}
[2023-10-30 06:31:54] INFO 5. VolumeExpansionSuite {pods: 1, volumes: 1, size: 8Gi, expSize: 16Gi, block: true}
[2023-10-30 06:31:54] INFO 6. SnapSuite {snapshots: 3, volumeSize; 8Gi}
[2023-10-30 06:31:54] INFO 7. ReplicationSuite {pods: 2, volumes: 5, volumeSize: 8Gi}
[2023-10-30 06:31:54] INFO 8. MultiAttachSuite {pods: 5, rawBlock: true, size: 8Gi, accMode: ReadWriteMany}
[2023-10-30 06:31:54] INFO Suites to run with vxflexos-xfs storage class:
[2023-10-30 06:31:54] INFO 1. ScalingSuite {replicas: 2, volumes: 5, volumeSize: 8Gi}
[2023-10-30 06:31:54] INFO 2. CloneVolumeSuite {pods: 2, volumes: 1, volumeSize: 8Gi}
[2023-10-30 06:31:54] INFO 3. VolumeIoSuite {volumes: 2, volumeSize: 8Gi chains: 2-2}
[2023-10-30 06:31:54] INFO 4. VolumeExpansionSuite {pods: 1, volumes: 1, size: 8Gi, expSize: 16Gi, block: false}
[2023-10-30 06:31:54] INFO 5. VolumeExpansionSuite {pods: 1, volumes: 1, size: 8Gi, expSize: 16Gi, block: true}
[2023-10-30 06:31:54] INFO 6. SnapSuite {snapshots: 3, volumeSize; 8Gi}
[2023-10-30 06:31:54] INFO 7. ReplicationSuite {pods: 2, volumes: 5, volumeSize: 8Gi}
[2023-10-30 06:31:54] INFO 8. MultiAttachSuite {pods: 5, rawBlock: true, size: 8Gi, accMode: ReadWriteMany}
Does it look OK? (Y)es/(n)o
-> y
/root/.cert-csi/reports/test-run-b2aff4ca/VolumeExpansionSuite37/PodCreation.png
BoxPlot:
/root/.cert-csi/reports/test-run-b2aff4ca/VolumeExpansionSuite37/PodCreation_boxplot.png
PodDeletion:
Avg: 1.615004355s
Min: 1.615004355s
Max: 1.615004355s
Histogram:
/root/.cert-csi/reports/test-run-b2aff4ca/VolumeExpansionSuite37/PodDeletion.png
BoxPlot:
/root/.cert-csi/reports/test-run-b2aff4ca/VolumeExpansionSuite37/PodDeletion_boxplot.png
EntityNumberOverTime:
/root/.cert-csi/reports/test-run-b2aff4ca/VolumeExpansionSuite37/EntityNumberOverTime.png
[2023-10-30 06:35:06] INFO Avg time of a run: 90.14s
[2023-10-30 06:35:06] INFO Avg time of a del: 17.54s
[2023-10-30 06:35:06] INFO Avg time of all: 115.08s
[2023-10-30 06:35:06] INFO During this run 100.0% of suites succeeded