Skip to content
This repository has been archived by the owner on Jun 26, 2021. It is now read-only.

Argument Resolution Refactoring #180

Open
justusschock opened this issue Aug 3, 2019 · 5 comments
Open

Argument Resolution Refactoring #180

justusschock opened this issue Aug 3, 2019 · 5 comments
Assignees
Labels
in progress Things that are currently developed

Comments

@justusschock
Copy link
Member

justusschock commented Aug 3, 2019

We should definately check where to give what argument (and maybe expose more keyword arguments) in experiment (Possible ways are to pass arguments via keyword or parameter object in __init__.py or run/test/resume/kfold, so there are 4 different ways to pass arguments)

We should probably do this, after merging #166

@justusschock
Copy link
Member Author

Any opinions, on what to pass which way @delira-dev/delira ?

I would prefer to expose as many options as possible and giving them good defaults, but things like loss functions, metrics, model parameters should be passed by the parameter object IMO.

@mibaumgartner
Copy link
Member

Maybe we should create a google docs/sheets document where we collect all parameters and decide where the respective argument should be passed?

@justusschock
Copy link
Member Author

You got the job :D

@mibaumgartner
Copy link
Member

@justusschock
Copy link
Member Author

So to summarize this:

Init:

  • model_cls
  • name
  • save_path
  • logging_type
  • logging_kwargs
  • convert_to_npy
  • key_mapping
  • verbose

train/resume/kfold:

  • params
  • val_score_key
  • optim_builder
  • checkpoint_freq
  • trainer_cls
  • gpu_ids
  • reduce_mode
  • datamgr

test

  • predictor_cls
  • model
  • prepare_batch
  • kwargs
  • datamgr
  • callbacks

params

  • n_epochs
  • metrics
  • metric_keys
  • losses
  • optim_cls
  • optim_params

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
in progress Things that are currently developed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants