Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/deprecate joins and exits #177

Merged
merged 9 commits into from
Jul 29, 2024
Merged

Feat/deprecate joins and exits #177

merged 9 commits into from
Jul 29, 2024

Conversation

wei3erHase
Copy link
Member

No description provided.

@wei3erHase wei3erHase marked this pull request as ready for review July 26, 2024 17:03
@wei3erHase wei3erHase requested a review from 0xteddybear July 26, 2024 17:03
0xteddybear
0xteddybear reviewed Jul 26, 2024
View reviewed changes
Copy link

@0xteddybear 0xteddybear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the mock_call_{join,exit}swap methods remain on MockBCoWPool
other than that, LGTM. No dead code anywhere.

0xteddybear
0xteddybear previously approved these changes Jul 26, 2024
View reviewed changes
@wei3erHase wei3erHase merged commit d140170 into dev Jul 29, 2024
4 checks passed
@wei3erHase wei3erHase deleted the feat/deprecate-joins-and-exits branch July 29, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xteddybear 0xteddybear 0xteddybear approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wei3erHase @0xteddybear