test: btt tests for joinswapPoolAmountOut #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wei3erHase
reviewed
Jul 22, 2024
Comment on lines
15
to
16
| ├── it queries the contracts token in balance | ||
| ├── it emits LOG_JOIN event for token |
There was a problem hiding this comment.
Suggested change
| ├── it queries the contracts token in balance | |
| ├── it emits LOG_JOIN event for token | |
| ├── it queries token in balance | |
| ├── it emits LOG_JOIN event for token in |
wei3erHase
reviewed
Jul 22, 2024
| ├── it emits LOG_JOIN event for token | ||
| ├── it mints the pool shares | ||
| ├── it sends pool shares to caller | ||
| ├── it calls _pullUnderlying for token |
There was a problem hiding this comment.
Suggested change
| ├── it calls _pullUnderlying for token | |
| ├── it calls _pullUnderlying for token in |
wei3erHase
requested changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.