Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate Improvements to gitlab-runner deployments for fleeting runners #128

Open
zachariahmiller opened this issue Oct 22, 2024 · 2 comments
Labels
enhancement ✨ New feature or request

Comments

@zachariahmiller
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Currently fleeting runner deployments are limited to a single runner pool and need to be deployed numerous times to include different instances sizes/pools.

There are a few issues with this including overhead and complexity of the deployment. This issue is a research spike on the feasibility of achieving some efficiencies in this process.

The areas that should be investigated:

  • Deploy x runner pools with one runner manager. This would be investigating if multiple [runners.autoscaling] configurations can be utilized in one runner manager
  • Deploy 1x fleeting plugin registry pod for N runner managers
  • Investigate and streamline the ability to deploy multiple runner managers and dependent autoscaling configs from a single gitlab-runner zarf package deployment

Describe the solution you'd like

Output of this should be follow on work to implement whatever was proved out as part of the investigation in this issue

Describe alternatives you've considered

use yaml anchors and numerous, largely redundant, helm overrides to faciliate deploying several sets of fleeting runners in a 1 to 1 to 1 of runner manager, runner registry and runner asg.

@zachariahmiller zachariahmiller added the enhancement ✨ New feature or request label Oct 22, 2024
@Racer159
Copy link
Contributor

Multiple [[runners]] blocks is currently not supported: https://gitlab.com/gitlab-org/charts/gitlab-runner/-/issues/532

@zachariahmiller
Copy link
Contributor Author

That's disappointing... particularly the closed MR on having the functionality added 2 years ago to then create several new issue about a different means of implementation that has not been touched.

Racer159 added a commit that referenced this issue Oct 28, 2024
…139)

## Description

This changes waits to be conditional in case the user overrides
namespaces.

## Related Issue

Relates to: #128

## Type of change

- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Other (security config, docs update, etc)

## Checklist before merging

- [x] Test, docs, adr added or updated as needed
- [x] [Contributor Guide
Steps](https://github.com/defenseunicorns/uds-package-gitlab-runner/blob/main/CONTRIBUTING.md#developer-workflow)
followed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants