feat: Custom init package for Nutanix CSI driver #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blancharda
suggested changes
May 1, 2024
There was a problem hiding this comment.
A few nits -- otherwise the changes look good!
One outstanding item is making sure we have the pepr policy exceptions in place. Let's update with main and update the existing rook-ceph exception accordingly (I would hazard a guess that this driver requires all the same permissions..)
…-factory-nutanix into NutanixCSI
…eployments so SC upgrades don't fail
blancharda
changed the title
blancharda
reviewed
May 3, 2024
blancharda
previously approved these changes
May 10, 2024
anthonywendt
previously approved these changes
May 10, 2024
…ftware-factory-nutanix into NutanixCSI
Co-authored-by: awendt <[email protected]>
anthonywendt
approved these changes
May 13, 2024
This was referenced Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.